diff options
| author |   Sam James <sam@gentoo.org> | 2023-06-13 22:52:12 +0100 |
|---|---|---|
| committer | Sam James <sam@gentoo.org> | 2023-06-15 22:12:15 +0100 |
| commit | 89925fc4e6d343ce6f7ca36bc288ba7b62d1193e (patch) | |
| tree | f6af5ea08958d5ac19c4f3a9b838408e08038652 /eclass | |
| parent | ruby-ng.eclass: optimize: use pattern for old ruby impls (diff) | |
| download | gentoo-89925fc4e6d343ce6f7ca36bc288ba7b62d1193e.tar.gz gentoo-89925fc4e6d343ce6f7ca36bc288ba7b62d1193e.tar.bz2 gentoo-89925fc4e6d343ce6f7ca36bc288ba7b62d1193e.zip | |
ruby-ng.eclass: optimize: use pattern substitution
We can save a little bit (consistently a few ms) by using patsubs in some
obvious cases.
Not really any difference globally, but for sinatra:
```
$ pk pkg source $(pkg) --repo ~/g/ --bench 5s # before
dev-ruby/sinatra-3.0.5::/home/sam/g/: mean: 76.25ms, min: 59.23ms, max: 83.674ms, σ = 4.247ms, N = 66
dev-ruby/sinatra-3.0.5-r1::/home/sam/g/: mean: 77.465ms, min: 61.782ms, max: 85.127ms, σ = 3.592ms, N = 65
dev-ruby/sinatra-3.0.6::/home/sam/g/: mean: 80.192ms, min: 60.922ms, max: 84.951ms, σ = 3.899ms, N = 63
dev-ruby/sinatra-2.2.3::/home/sam/g/: mean: 80.389ms, min: 56.818ms, max: 86.915ms, σ = 4.508ms, N = 63
$ pk pkg source $(pkg) --repo ~/g/ --bench 5s # after
dev-ruby/sinatra-2.2.3::/home/sam/g/: mean: 66.68ms, min: 56.938ms, max: 74.248ms, σ = 4.832ms, N = 75
dev-ruby/sinatra-3.0.6::/home/sam/g/: mean: 73.618ms, min: 60.153ms, max: 77.978ms, σ = 3.195ms, N = 68
dev-ruby/sinatra-3.0.5::/home/sam/g/: mean: 72.069ms, min: 58.736ms, max: 78.223ms, σ = 3.277ms, N = 70
dev-ruby/sinatra-3.0.5-r1::/home/sam/g/: mean: 73.265ms, min: 60.738ms, max: 81.06ms, σ = 3.227ms, N = 69
```
Bug: https://bugs.gentoo.org/908465
Signed-off-by: Sam James <sam@gentoo.org>
Diffstat (limited to 'eclass')
| -rw-r--r-- | eclass/ruby-ng.eclass | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass index 5a6edb1bf608..2bf1885d3803 100644 --- a/eclass/ruby-ng.eclass +++ b/eclass/ruby-ng.eclass @@ -183,11 +183,11 @@ _ruby_wrap_conditions() { local conditions="$1" local atoms="$2" - for condition in $conditions; do + for condition in ${conditions}; do atoms="${condition}? ( ${atoms} )" done - echo "$atoms" + echo "${atoms}" } # @FUNCTION: ruby_add_rdepend @@ -322,11 +322,9 @@ ruby_get_use_implementations() { ruby_get_use_targets() { debug-print-function ${FUNCNAME} "${@}" - local t implementation - for implementation in $(_ruby_get_all_impls); do - t+=" ruby_targets_${implementation}" - done - echo $t + + local impls="$(_ruby_get_all_impls)" + echo "${impls//ruby/ruby_targets_ruby}" } # @FUNCTION: ruby_implementations_depend |