summaryrefslogtreecommitdiff
blob: 364d112b45a4e02d053b7588858bdcf90a4efd07 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
https://github.com/bbangert/beaker/commit/714f464cac9d14e338cf4420163292acaab3bb49
diff --git a/beaker/session.py b/beaker/session.py
index 10a87f2..f1a585f 100644
--- a/beaker/session.py
+++ b/beaker/session.py
@@ -226,7 +226,7 @@ def _create_id(self, set_new=True):
             self.last_accessed = None
         if self.use_cookies:
             self._set_cookie_values()
-            sc = set_new == False
+            sc = set_new is False
             self._update_cookie_out(set_cookie=sc)
 
     @property
diff --git a/tests/test_session.py b/tests/test_session.py
index 82ed74d..926dabb 100644
--- a/tests/test_session.py
+++ b/tests/test_session.py
@@ -218,7 +218,8 @@ def test_cookies_enabled():
 
     # test for secure
     session = get_session(use_cookies=True, secure=True)
-    assert 'secure' in session.request['cookie_out']
+    cookie = session.request['cookie_out'].lower()  # Python3.4.3 outputs "Secure", while previous output "secure"
+    assert 'secure' in cookie, cookie
 
     # test for httponly
     class ShowWarning(object):
@@ -233,7 +234,9 @@ def __call__(self, message, category, filename, lineno, file=None, line=None):
     if sys.version_info < (2, 6):
         assert sw.msg == 'Python 2.6+ is required to use httponly'
     else:
-        assert 'httponly' in session.request['cookie_out']
+        # Python3.4.3 outputs "HttpOnly", while previous output "httponly"
+        cookie = session.request['cookie_out'].lower()
+        assert 'httponly' in cookie, cookie
     warnings.showwarning = orig_sw
 
 def test_cookies_disabled():