*/*: [QA] Remove redundant `|| die` guards

* Since all ebuilds in the tree are EAPI>=4,
  `|| die` on builtin commands is redundant
  and dead code.

Closes: https://github.com/gentoo/gentoo/pull/13940
Reviewed-by: Ulrich Müller <ulm@gentoo.org>
Reviewed-by: Michał Górny <mgorny@gentoo.org>
Reviewed-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Signed-off-by: David Seifert <soap@gentoo.org>

5 files changed, 12 insertions, 14 deletions

diff --git a/sci-mathematics/msieve/msieve-1.51-r1.ebuild b/sci-mathematics/msieve/msieve-1.51-r1.ebuild
index 0b4672d57dc6..25cedcc0c961 100644
--- a/sci-mathematics/msieve/msieve-1.51-r1.ebuild
+++ b/sci-mathematics/msieve/msieve-1.51-r1.ebuild
@@ -49,6 +49,6 @@ src_install() {
 	mkdir -p "${D}/usr/share/doc/${P}/"
 	cp include/* "${D}/usr/include/msieve" || die "Failed to install"
 	cp libmsieve.a "${D}/usr/lib/" || die "Failed to install"
-	dobin msieve || die "Failed to install"
+	dobin msieve
 	cp Readme* "${D}/usr/share/doc/${P}/" || die "Failed to install"
 }
diff --git a/sci-mathematics/msieve/msieve-1.53-r1.ebuild b/sci-mathematics/msieve/msieve-1.53-r1.ebuild
index 67933ca55dfd..f590609455e3 100644
--- a/sci-mathematics/msieve/msieve-1.53-r1.ebuild
+++ b/sci-mathematics/msieve/msieve-1.53-r1.ebuild
@@ -51,6 +51,6 @@ src_install() {
 	mkdir -p "${ED%/}/usr/share/doc/${P}/"
 	cp include/* "${ED%/}/usr/include/msieve" || die "Failed to install"
 	cp libmsieve.a "${ED%/}/usr/lib/" || die "Failed to install"
-	dobin msieve || die "Failed to install"
+	dobin msieve
 	cp Readme* "${ED%/}/usr/share/doc/${P}/" || die "Failed to install"
 }
diff --git a/sci-mathematics/msieve/msieve-9999.ebuild b/sci-mathematics/msieve/msieve-9999.ebuild
index d5ad2a8ec1b9..72fa0aaf997f 100644
--- a/sci-mathematics/msieve/msieve-9999.ebuild
+++ b/sci-mathematics/msieve/msieve-9999.ebuild
@@ -45,6 +45,6 @@ src_install() {
 	mkdir -p "${D}/usr/share/doc/${P}/"
 	cp include/* "${D}/usr/include/msieve" || die "Failed to install"
 	cp libmsieve.a "${D}/usr/lib/" || die "Failed to install"
-	dobin msieve || die "Failed to install"
+	dobin msieve
 	cp Readme* "${D}/usr/share/doc/${P}/" || die "Failed to install"
 }
diff --git a/sci-mathematics/singular/singular-4.0.2.ebuild b/sci-mathematics/singular/singular-4.0.2.ebuild
index fd44a959ad62..114d83fd0a31 100644
--- a/sci-mathematics/singular/singular-4.0.2.ebuild
+++ b/sci-mathematics/singular/singular-4.0.2.ebuild
@@ -80,7 +80,7 @@ src_configure() {
 }
 
 src_compile() {
-	emake || die "emake failed"
+	emake
 
 	if use emacs; then
 		cd "${MY_SHARE_DIR}"singular/emacs/
@@ -92,26 +92,24 @@ src_compile() {
 # 	dodoc README
 # 	# execs and libraries
 # 	cd "${S}"/build/bin
-# 	dobin ${MY_PN}* gen_test change_cost solve_IP toric_ideal LLL \
-# 		|| die "failed to install binaries"
+# 	dobin ${MY_PN}* gen_test change_cost solve_IP toric_ideal LLL
 # 	insinto /usr/$(get_libdir)/${PN}
-# 	doins *.so || die "failed to install libraries"
+# 	doins *.so
 #
-# 	dosym ${MY_PN}-${MY_DIR} /usr/bin/${MY_PN} \
-# 		|| die "failed to create symbolic link"
+# 	dosym ${MY_PN}-${MY_DIR} /usr/bin/${MY_PN}
 #
 # 	# stuff from the share tar ball
 # 	cd "${WORKDIR}"/${MY_PN}/${MY_SHARE_DIR}
 # 	insinto /usr/share/${PN}
-# 	doins -r LIB  || die "failed to install lib files"
+# 	doins -r LIB
 # 	if use examples; then
 # 		insinto /usr/share/doc/${PF}
-# 		doins -r examples || die "failed to install examples"
+# 		doins -r examples
 # 	fi
 # 	if use doc; then
-# 		dohtml -r html/* || die "failed to install html docs"
+# 		dohtml -r html/*
 # 		insinto /usr/share/${PN}
-# 		doins doc/singular.idx || die "failed to install idx file"
+# 		doins doc/singular.idx
 # 		cp info/${PN}.hlp info/${PN}.info &&
 # 		doinfo info/${PN}.info \
 # 			|| die "failed to install info files"
diff --git a/sci-mathematics/singular/singular-4.0.3.ebuild b/sci-mathematics/singular/singular-4.0.3.ebuild
index 819a33a186cc..6d898b9c9fcb 100644
--- a/sci-mathematics/singular/singular-4.0.3.ebuild
+++ b/sci-mathematics/singular/singular-4.0.3.ebuild
@@ -74,7 +74,7 @@ src_configure() {
 }
 
 src_compile() {
-	emake || die "emake failed"
+	emake
 
 	if use emacs; then
 		cd "${S}"/emacs/