diff options
| author |   Oskari Pirhonen <xxc3ncoredxx@gmail.com> | 2023-04-01 15:10:20 -0500 |
|---|---|---|
| committer |   Sam James <sam@gentoo.org> | 2023-04-02 20:17:09 +0100 |
| commit | 7c75dd616afa8db25254aa34928360e9549b6e35 (patch) | |
| tree | da1f8cd540d37af7be2306e7de095cab6f7c4d74 /NEWS | |
| parent | man/ru/ebuild.1: Fix grammar (diff) | |
| download | portage-7c75dd616afa8db25254aa34928360e9549b6e35.tar.gz portage-7c75dd616afa8db25254aa34928360e9549b6e35.tar.bz2 portage-7c75dd616afa8db25254aa34928360e9549b6e35.zip | |
tests: fix util/test_shelve.py
Remove the `os.unlink()` call which can fail if the backend lib, eg,
adds a suffix to the filename. When debugging this failed run [1], the
`shelve_file` was being created as `shelve_file.db`.
From the Python docs:
The filename parameter is the base filename for the underlying
database. As a side-effect, an extension may be added to the
filename and more than one file may be created.
Test failure:
ERROR: test_dump_restore (portage.tests.util.test_shelve.ShelveUtilsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/build/portage/build/lib/portage/tests/__init__.py", line 274, in run
testMethod()
File "/home/build/portage/build/lib/portage/tests/util/test_shelve.py", line 47, in test_dump_restore
os.unlink(dump_args.src)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpjq543rhp/shelve_file'
[1]: https://builds.sr.ht/~xxc3nsoredxx/job/966549
Signed-off-by: Oskari Pirhonen <xxc3ncoredxx@gmail.com>
Closes: https://github.com/gentoo/portage/pull/1017
Signed-off-by: Sam James <sam@gentoo.org>
Diffstat (limited to 'NEWS')
| -rw-r--r-- | NEWS | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -56,7 +56,8 @@ Features: for a time for compatibility. Bug fixes: -* TODO +* tests: util/test_shelve: fix test failure if the backend for the shelve module + does not create the shelve db using the literal filename. portage-3.0.45.3 (2023-03-19) ---------------- |