aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArthur Zamarin <arthurzam@gentoo.org>2024-01-13 11:46:54 +0200
committerArthur Zamarin <arthurzam@gentoo.org>2024-01-14 20:14:37 +0200
commit4007f00c7833aae6e455ee1b50d50a7c1d10799f (patch)
tree2865e2d98c46d1fd568644b723ef8483bd7d881f /testdata
parentDockerfile: introduce pkgcheck docker on release (diff)
downloadpkgcheck-4007f00c7833aae6e455ee1b50d50a7c1d10799f.tar.gz
pkgcheck-4007f00c7833aae6e455ee1b50d50a7c1d10799f.tar.bz2
pkgcheck-4007f00c7833aae6e455ee1b50d50a7c1d10799f.zip
SandboxCallCheck: new check for invalid sandbox calls
Catches multiple arguments passed to function, and colon separated path. Resolves: https://github.com/pkgcore/pkgcheck/issues/644 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Diffstat (limited to 'testdata')
-rw-r--r--testdata/data/repos/standalone/SandboxCallCheck/InvalidSandboxCall/expected.json2
-rw-r--r--testdata/data/repos/standalone/SandboxCallCheck/InvalidSandboxCall/fix.patch17
-rw-r--r--testdata/repos/standalone/SandboxCallCheck/InvalidSandboxCall/InvalidSandboxCall-0.ebuild12
3 files changed, 31 insertions, 0 deletions
diff --git a/testdata/data/repos/standalone/SandboxCallCheck/InvalidSandboxCall/expected.json b/testdata/data/repos/standalone/SandboxCallCheck/InvalidSandboxCall/expected.json
new file mode 100644
index 00000000..bb9a6894
--- /dev/null
+++ b/testdata/data/repos/standalone/SandboxCallCheck/InvalidSandboxCall/expected.json
@@ -0,0 +1,2 @@
+{"__class__": "InvalidSandboxCall", "category": "SandboxCallCheck", "package": "InvalidSandboxCall", "version": "0", "line": "addpredict /etc/dfs:/dev/zfs", "lineno": 7}
+{"__class__": "InvalidSandboxCall", "category": "SandboxCallCheck", "package": "InvalidSandboxCall", "version": "0", "line": "addwrite /dev /etc", "lineno": 11}
diff --git a/testdata/data/repos/standalone/SandboxCallCheck/InvalidSandboxCall/fix.patch b/testdata/data/repos/standalone/SandboxCallCheck/InvalidSandboxCall/fix.patch
new file mode 100644
index 00000000..7f28be1a
--- /dev/null
+++ b/testdata/data/repos/standalone/SandboxCallCheck/InvalidSandboxCall/fix.patch
@@ -0,0 +1,17 @@
+diff -Naur standalone/SandboxCallCheck/InvalidSandboxCall/InvalidSandboxCall-0.ebuild fixed/SandboxCallCheck/InvalidSandboxCall/InvalidSandboxCall-0.ebuild
+--- standalone/SandboxCallCheck/InvalidSandboxCall/InvalidSandboxCall-0.ebuild
++++ fixed/SandboxCallCheck/InvalidSandboxCall/InvalidSandboxCall-0.ebuild
+@@ -4,9 +4,11 @@ SLOT="0"
+ LICENSE="BSD"
+
+ src_compile() {
+- addpredict /etc/dfs:/dev/zfs
++ addpredict /etc/dfs
++ addpredict /dev/zfs
+ }
+
+ src_test() {
+- addwrite /dev /etc
++ addwrite /dev
++ addwrite /etc
+ }
diff --git a/testdata/repos/standalone/SandboxCallCheck/InvalidSandboxCall/InvalidSandboxCall-0.ebuild b/testdata/repos/standalone/SandboxCallCheck/InvalidSandboxCall/InvalidSandboxCall-0.ebuild
new file mode 100644
index 00000000..97062656
--- /dev/null
+++ b/testdata/repos/standalone/SandboxCallCheck/InvalidSandboxCall/InvalidSandboxCall-0.ebuild
@@ -0,0 +1,12 @@
+DESCRIPTION="Ebuild with invalid sandbox calls"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+SLOT="0"
+LICENSE="BSD"
+
+src_compile() {
+ addpredict /etc/dfs:/dev/zfs
+}
+
+src_test() {
+ addwrite /dev /etc
+}