1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
|
/**
* virconsole.c: api to guarantee mutually exclusive
* access to domain's consoles
*
* Copyright (C) 2011-2012 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*
* Author: Peter Krempa <pkrempa@redhat.com>
*/
#include <config.h>
#include <fcntl.h>
#include <unistd.h>
#include <sys/types.h>
#include "virconsole.h"
#include "virhash.h"
#include "fdstream.h"
#include "internal.h"
#include "threads.h"
#include "memory.h"
#include "virpidfile.h"
#include "logging.h"
#include "virterror_internal.h"
#include "virfile.h"
#define VIR_FROM_THIS VIR_FROM_NONE
/* structure holding information about consoles
* open in a given domain */
struct _virConsoles {
virMutex lock;
virHashTablePtr hash;
};
typedef struct _virConsoleStreamInfo virConsoleStreamInfo;
typedef virConsoleStreamInfo *virConsoleStreamInfoPtr;
struct _virConsoleStreamInfo {
virConsolesPtr cons;
const char *pty;
};
#ifdef VIR_PTY_LOCK_FILE_PATH
/**
* Create a full filename with path to the lock file based on
* name/path of corresponding pty
*
* @pty path of the console device
*
* Returns a modified name that the caller has to free, or NULL
* on error.
*/
static char *virConsoleLockFilePath(const char *pty)
{
char *path = NULL;
char *sanitizedPath = NULL;
char *ptyCopy;
char *filename;
char *p;
if (!(ptyCopy = strdup(pty))) {
virReportOOMError();
goto cleanup;
}
/* skip the leading "/dev/" */
filename = STRSKIP(ptyCopy, "/dev");
if (!filename)
filename = ptyCopy;
/* substitute path forward slashes for underscores */
p = filename;
while (*p) {
if (*p == '/')
*p = '_';
++p;
}
if (virAsprintf(&path, "%s/LCK..%s", VIR_PTY_LOCK_FILE_PATH, filename) < 0)
goto cleanup;
sanitizedPath = virFileSanitizePath(path);
cleanup:
VIR_FREE(path);
VIR_FREE(ptyCopy);
return sanitizedPath;
}
/**
* Verify and create a lock file for a console pty
*
* @pty Path of the console device
*
* Returns 0 on success, -1 on error
*/
static int virConsoleLockFileCreate(const char *pty)
{
char *path = NULL;
int ret = -1;
int lockfd = -1;
char *pidStr = NULL;
pid_t pid;
/* build lock file path */
if (!(path = virConsoleLockFilePath(pty)))
goto cleanup;
/* check if a log file and process holding the lock still exists */
if (virPidFileReadPathIfAlive(path, &pid, NULL) == 0 && pid >= 0) {
/* the process exists, the lockfile is valid */
virReportError(VIR_ERR_OPERATION_FAILED,
_("Requested console pty '%s' is locked by "
"lock file '%s' held by process %lld"),
pty, path, (long long) pid);
goto cleanup;
} else {
/* clean up the stale/corrupted/nonexistent lockfile */
unlink(path);
}
/* lockfile doesn't (shouldn't) exist */
/* ensure correct format according to filesystem hierarchy standard */
/* http://www.pathname.com/fhs/pub/fhs-2.3.html#VARLOCKLOCKFILES */
if (virAsprintf(&pidStr, "%10lld\n", (long long) getpid()) < 0)
goto cleanup;
/* create the lock file */
if ((lockfd = open(path, O_WRONLY | O_CREAT | O_EXCL, 00644)) < 0) {
/* If we run in session mode, we might have no access to the lock
* file directory. We have to check for an permission denied error
* and see if we can reach it. This should cause an error only if
* we run in daemon mode and thus privileged.
*/
if (errno == EACCES && geteuid() != 0) {
VIR_DEBUG("Skipping lock file creation for pty '%s in path '%s'.",
pty, path);
ret = 0;
goto cleanup;
}
virReportSystemError(errno,
_("Couldn't create lock file for "
"pty '%s' in path '%s'"),
pty, path);
goto cleanup;
}
/* write the pid to the file */
if (safewrite(lockfd, pidStr, strlen(pidStr)) < 0) {
virReportSystemError(errno,
_("Couldn't write to lock file for "
"pty '%s' in path '%s'"),
pty, path);
VIR_FORCE_CLOSE(lockfd);
unlink(path);
goto cleanup;
}
/* we hold the lock */
ret = 0;
cleanup:
VIR_FORCE_CLOSE(lockfd);
VIR_FREE(path);
VIR_FREE(pidStr);
return ret;
}
/**
* Remove a lock file for a pty
*
* @pty Path of the pty device
*/
static void virConsoleLockFileRemove(const char *pty)
{
char *path = virConsoleLockFilePath(pty);
if (path)
unlink(path);
VIR_FREE(path);
}
#else /* #ifdef VIR_PTY_LOCK_FILE_PATH */
/* file locking for console devices is disabled */
static int virConsoleLockFileCreate(const char *pty ATTRIBUTE_UNUSED)
{
return 0;
}
static void virConsoleLockFileRemove(const char *pty ATTRIBUTE_UNUSED)
{
return;
}
#endif /* #ifdef VIR_PTY_LOCK_FILE_PATH */
/**
* Frees an entry from the hash containing domain's active consoles
*
* @data Opaque data, struct holding information about the console
* @name Path of the pty.
*/
static void virConsoleHashEntryFree(void *data,
const void *name)
{
const char *pty = name;
virStreamPtr st = data;
/* free stream reference */
virStreamFree(st);
/* delete lock file */
virConsoleLockFileRemove(pty);
}
/**
* Frees opaque data provided for the stream closing callback
*
* @opaque Data to be freed.
*/
static void virConsoleFDStreamCloseCbFree(void *opaque)
{
virConsoleStreamInfoPtr priv = opaque;
VIR_FREE(priv->pty);
VIR_FREE(priv);
}
/**
* Callback being called if a FDstream is closed. Frees console entries
* from data structures and removes lockfiles.
*
* @st Pointer to stream being closed.
* @opaque Domain's console information structure.
*/
static void virConsoleFDStreamCloseCb(virStreamPtr st ATTRIBUTE_UNUSED,
void *opaque)
{
virConsoleStreamInfoPtr priv = opaque;
virMutexLock(&priv->cons->lock);
/* remove entry from hash */
virHashRemoveEntry(priv->cons->hash, priv->pty);
virMutexUnlock(&priv->cons->lock);
}
/**
* Allocate structures for storing information about active console streams
* in domain's private data section.
*
* Returns pointer to the allocated structure or NULL on error
*/
virConsolesPtr virConsoleAlloc(void)
{
virConsolesPtr cons;
if (VIR_ALLOC(cons) < 0)
return NULL;
if (virMutexInit(&cons->lock) < 0) {
VIR_FREE(cons);
return NULL;
}
/* there will hardly be any consoles most of the time, the hash
* does not have to be huge */
if (!(cons->hash = virHashCreate(3, virConsoleHashEntryFree)))
goto error;
return cons;
error:
virConsoleFree(cons);
return NULL;
}
/**
* Helper to clear stream callbacks when freeing the hash
*/
static void virConsoleFreeClearCallbacks(void *payload,
const void *name ATTRIBUTE_UNUSED,
void *data ATTRIBUTE_UNUSED)
{
virStreamPtr st = payload;
virFDStreamSetInternalCloseCb(st, NULL, NULL, NULL);
}
/**
* Free structures for handling open console streams.
*
* @cons Pointer to the private structure.
*/
void virConsoleFree(virConsolesPtr cons)
{
if (!cons || !cons->hash)
return;
virMutexLock(&cons->lock);
virHashForEach(cons->hash, virConsoleFreeClearCallbacks, NULL);
virHashFree(cons->hash);
virMutexUnlock(&cons->lock);
virMutexDestroy(&cons->lock);
VIR_FREE(cons);
}
/**
* Open a console stream for a domain ensuring that other streams are
* not using the console, nor any lockfiles exist. This ensures that
* the console stream does not get corrupted due to a race on reading
* same FD by two processes.
*
* @cons Pointer to private structure holding data about console streams.
* @pty Path to the pseudo tty to be opened.
* @st Stream the client wishes to use for the console connection.
* @force On true, close active console streams for the selected console pty
* before opening this connection.
*
* Returns 0 on success and st is connected to the selected pty and
* corresponding lock file is created (if configured). Returns -1 on
* error and 1 if the console stream is open and busy.
*/
int virConsoleOpen(virConsolesPtr cons,
const char *pty,
virStreamPtr st,
bool force)
{
virConsoleStreamInfoPtr cbdata = NULL;
virStreamPtr savedStream;
int ret;
virMutexLock(&cons->lock);
if ((savedStream = virHashLookup(cons->hash, pty))) {
if (!force) {
/* entry found, console is busy */
virMutexUnlock(&cons->lock);
return 1;
} else {
/* terminate existing connection */
/* The internal close callback handler needs to lock cons->lock to
* remove the aborted stream from the hash. This would cause a
* deadlock as we would try to enter the lock twice from the very
* same thread. We need to unregister the callback and abort the
* stream manually before we create a new console connection.
*/
virFDStreamSetInternalCloseCb(savedStream, NULL, NULL, NULL);
virStreamAbort(savedStream);
virHashRemoveEntry(cons->hash, pty);
/* continue adding a new stream connection */
}
}
/* create the lock file */
if ((ret = virConsoleLockFileCreate(pty)) < 0) {
virMutexUnlock(&cons->lock);
return ret;
}
/* obtain a reference to the stream */
if (virStreamRef(st) < 0) {
virMutexUnlock(&cons->lock);
return -1;
}
if (VIR_ALLOC(cbdata) < 0) {
virReportOOMError();
goto error;
}
if (virHashAddEntry(cons->hash, pty, st) < 0)
goto error;
cbdata->cons = cons;
if (!(cbdata->pty = strdup(pty))) {
virReportOOMError();
goto error;
}
/* open the console pty */
if (virFDStreamOpenFile(st, pty, 0, 0, O_RDWR) < 0)
goto error;
/* add cleanup callback */
virFDStreamSetInternalCloseCb(st,
virConsoleFDStreamCloseCb,
cbdata,
virConsoleFDStreamCloseCbFree);
virMutexUnlock(&cons->lock);
return 0;
error:
virStreamFree(st);
virHashRemoveEntry(cons->hash, pty);
if (cbdata)
VIR_FREE(cbdata->pty);
VIR_FREE(cbdata);
virMutexUnlock(&cons->lock);
return -1;
}
|