aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Brobecker <brobecker@adacore.com>2018-06-29 18:42:27 -0400
committerJoel Brobecker <brobecker@adacore.com>2018-06-29 18:51:18 -0400
commit41206e32fb909ebacf6db009fc1f177bde74a652 (patch)
tree1faf4792ef13f06a449b3ccd4c058fd6c777e090 /gdb/amd64-fbsd-nat.c
parentRISC-V: Add gas support for "fp" register. (diff)
downloadbinutils-gdb-41206e32fb909ebacf6db009fc1f177bde74a652.tar.gz
binutils-gdb-41206e32fb909ebacf6db009fc1f177bde74a652.tar.bz2
binutils-gdb-41206e32fb909ebacf6db009fc1f177bde74a652.zip
fix GDB build failure for various amd64 targets
The following patch caused some amd64-*-tdep files to fail to compile: | commit de52b9607d2623f18b7a7dbee3e1123d8d63f5da | Date: Tue Jun 26 16:33:27 2018 +0100 | Subject: x86_64-windows GDB crash due to fs_base/gs_base registers This is because we added one additional "segments" argument to function amd64_target_description and forgot to update all the callers. This patch fixes the omissions. gdb/ChangeLog: * amd64-darwin-tdep.c (x86_darwin_init_abi_64): Add missing parameter in call to amd64_target_description. * amd64-dicos-tdep.c (amd64_dicos_init_abi): Likewise. * amd64-fbsd-tdep.c (amd64fbsd_core_read_description) (amd64fbsd_init_abi): Likewise. * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise. * amd64-obsd-tdep.c (amd64obsd_init_abi): Likewise. * amd64-sol2-tdep.c (amd64_sol2_init_abi): Likewise. * amd64-fbsd-nat.c (amd64_fbsd_nat_target): Likewise. The change to amd64-fbsd-nat.c was done "blind" (no access to system), but is reasonably straightforward. The changes to the -tdep.c files were verify by rebuilding GDB on x86_64-linux when configured with --enable-targets=all.
Diffstat (limited to 'gdb/amd64-fbsd-nat.c')
-rw-r--r--gdb/amd64-fbsd-nat.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/amd64-fbsd-nat.c b/gdb/amd64-fbsd-nat.c
index 6b0367b5d65..f9b1bcae2e6 100644
--- a/gdb/amd64-fbsd-nat.c
+++ b/gdb/amd64-fbsd-nat.c
@@ -188,13 +188,13 @@ amd64_fbsd_nat_target::read_description ()
if (x86bsd_xsave_len != 0)
{
if (is64)
- return amd64_target_description (xcr0);
+ return amd64_target_description (xcr0, true);
else
return i386_target_description (xcr0);
}
#endif
if (is64)
- return amd64_target_description (X86_XSTATE_SSE_MASK);
+ return amd64_target_description (X86_XSTATE_SSE_MASK, true);
else
return i386_target_description (X86_XSTATE_SSE_MASK);
}