diff options
| author |   Nick Clifton <nickc@redhat.com> | 2014-11-26 14:11:23 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2014-11-26 14:11:23 +0000 |
| commit | a11652892c18324bf3abb8b25c01475e5a18632a (patch) | |
| tree | 651732ecd80594056102f5b551cc7ed6f0b5143f /bfd/coff-ia64.c | |
| parent | Recognize new DWARFv5 C11, C++11 and C++14 DW_LANG constants. (diff) | |
| download | binutils-gdb-a11652892c18324bf3abb8b25c01475e5a18632a.tar.gz binutils-gdb-a11652892c18324bf3abb8b25c01475e5a18632a.tar.bz2 binutils-gdb-a11652892c18324bf3abb8b25c01475e5a18632a.zip | |
More fixes for memory access errors triggered by attemps to examine corrupted binaries.
PR binutils/17512
* dwarf.c (display_block): Do nothing if the block starts after
the end of the buffer.
(read_and_display_attr_value): Add range checks.
(struct Frame_Chunk): Make the ncols and ra fields unsigned.
(frame_need_space): Test for an ncols of zero.
(read_cie): Fail if the augmentation data extends off the end of
the buffer.
(display_debug_frames): Add checks for read_cie failing. Add
range checks.
* coff-h8300.c (rtype2howto): Replace abort with returning a NULL
value.
* coff-h8500.c (rtype2howto): Likewise.
* coff-tic30.c (rtype2howto): Likewise.
* coff-z80.c (rtype2howto): Likewise.
* coff-z8k.c (rtype2howto): Likewise.
* coff-ia64.c (RTYPE2HOWTO): Always return a valid howto.
* coff-m68k.c (m68k_rtype2howto): Return a NULL howto if none
could be found.
* coff-mcore.c (RTYPE2HOWTO): Add range checking.
* coff-w65.c (rtype2howto): Likewise.
* coff-we32k.c (RTYPE2HOWTO): Likewise.
* pe-mips.c (RTYPE2HOWTO): Likewise.
* coff-x86_64.c (coff_amd64_reloc): Likewise. Replace abort with
an error return.
* coffcode.h (coff_slurp_reloc_table): Allow the rel parameter to
be unused.
* coffgen.c (make_a_section_from_file): Check the length of a
section name before testing to see if it is a debug section name.
(coff_object_p): Zero out any uninitialised bytes in the opt
header.
* ecoff.c (_bfd_ecoff_slurp_symbolic_info): Test for the raw
source being empty when there are values to be processed.
(_bfd_ecoff_slurp_symbol_table): Add range check.
* mach-o.c (bfd_mach_o_canonicalize_one_reloc): Likewise.
(bfd_mach_o_mangle_sections): Move test for too many sections to
before the allocation of the section table.
(bfd_mach_o_read_symtab_strtab): If the read fails, free the
memory and nullify the symbol pointer.
* reloc.c (bfd_generic_get_relocated_section_contents): Add
handling of a bfd_reloc_notsupported return value.
* versados.c (EDATA): Add range checking.
(get_record): Likewise.
(process_otr): Check for contents being available before updating
them.
(versados_canonicalize_reloc): Add range check.
Diffstat (limited to 'bfd/coff-ia64.c')
| -rw-r--r-- | bfd/coff-ia64.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bfd/coff-ia64.c b/bfd/coff-ia64.c index 38a0a381f13..f1641dbbdad 100644 --- a/bfd/coff-ia64.c +++ b/bfd/coff-ia64.c @@ -47,7 +47,7 @@ static reloc_howto_type howto_table[] = #endif #define RTYPE2HOWTO(cache_ptr, dst) \ - (cache_ptr)->howto = howto_table + (dst)->r_type; + (cache_ptr)->howto = howto_table; #ifdef COFF_WITH_PE /* Return TRUE if this relocation should |