summaryrefslogtreecommitdiff
blob: 2d3a22feba774dab1dcc3b95a5495503002cf0b6 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
From 7cbb17396d6ae1c2292f4a2cedf4f3da2a70435e Mon Sep 17 00:00:00 2001
From: Mu Qiao <qiaomuf@gmail.com>
Date: Wed, 18 Aug 2010 21:02:04 +0800
Subject: [PATCH] reading: Completely ignore invalid connections
 Signed-off-by: Mu Qiao <qiaomuf@gmail.com>

---
 system-settings/plugins/ifnet/connection_parser.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/system-settings/plugins/ifnet/connection_parser.c b/system-settings/plugins/ifnet/connection_parser.c
index 9634ba4..f9fae51 100644
--- a/system-settings/plugins/ifnet/connection_parser.c
+++ b/system-settings/plugins/ifnet/connection_parser.c
@@ -1698,10 +1698,10 @@ ifnet_update_connection_from_config_block (gchar * conn_name, GError ** error)
 	if (error && *error)
 		PLUGIN_WARN (IFNET_PLUGIN_NAME,
 			     "Found error: %s", (*error)->message);
-	if (!success)
-		g_object_unref (setting);
 	PLUGIN_PRINT (IFNET_PLUGIN_NAME, "Connection verified %s:%d", conn_name,
 		      success);
+	if (!success)
+		goto error;
 	return connection;
       error:
 	g_object_unref (setting);
-- 
1.6.1