Added -fsigned-char to sox-12.17.4-r2 and sox-12.17.5-r1 to fix bug #35745. Patch for wav segfaults in sox-12.17.5-r1, also bug #35745

4 files changed, 28 insertions, 6 deletions

diff --git a/media-sound/sox/ChangeLog b/media-sound/sox/ChangeLog
index 876cedd3b59a..93e9cef884fc 100644
--- a/media-sound/sox/ChangeLog
+++ b/media-sound/sox/ChangeLog
@@ -1,6 +1,12 @@
 # ChangeLog for media-sound/sox
 # Copyright 2002-2004 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/media-sound/sox/ChangeLog,v 1.32 2004/09/14 07:43:30 eradicator Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-sound/sox/ChangeLog,v 1.33 2004/10/17 23:43:09 josejx Exp $
+
+  18 Oct 2004; Joseph Jezak <josejx@gentoo.org>
+  +files/sox-wav-segfault.patch, sox-12.17.4-r2.ebuild,
+  sox-12.17.5-r1.ebuild:
+  Added -fsigned-char to sox-12.17.4-r2 and sox-12.17.5-r1 to fix bug #35745.
+  Patch for wav segfaults in sox-12.17.5-r1, also bug #35745
 
   14 Sep 2004; Jeremy Huddleston <eradicator@gentoo.org> :
   Removing sox-12.17.5 as it installs exactly the same thing as -r1. -r1 should
diff --git a/media-sound/sox/files/sox-wav-segfault.patch b/media-sound/sox/files/sox-wav-segfault.patch
new file mode 100644
index 000000000000..efdda66477f6
--- /dev/null
+++ b/media-sound/sox/files/sox-wav-segfault.patch
@@ -0,0 +1,11 @@
+--- wav.c	2004-08-25 23:12:11.660273688 -0400
++++ sox-12.17.5/wav.c	2004-08-25 23:12:21.706746392 -0400
+@@ -1088,7 +1088,7 @@
+ 
+     if (ft->comment) 
+     {
+-        free(ft->comment);
++        /* free(ft->comment); */
+         ft->comment = 0;
+     }
+ 
diff --git a/media-sound/sox/sox-12.17.4-r2.ebuild b/media-sound/sox/sox-12.17.4-r2.ebuild
index 8e525cfd200f..f6fa75293f8b 100644
--- a/media-sound/sox/sox-12.17.4-r2.ebuild
+++ b/media-sound/sox/sox-12.17.4-r2.ebuild
@@ -1,8 +1,8 @@
 # Copyright 1999-2004 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-sound/sox/sox-12.17.4-r2.ebuild,v 1.3 2004/08/11 20:40:35 ferringb Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-sound/sox/sox-12.17.4-r2.ebuild,v 1.4 2004/10/17 23:43:09 josejx Exp $
 
-inherit gnuconfig eutils
+inherit gnuconfig eutils flag-o-matic
 
 DESCRIPTION="The swiss army knife of sound processing programs"
 HOMEPAGE="http://sox.sourceforge.net"
@@ -19,7 +19,6 @@ DEPEND="virtual/libc
 	mad? ( media-sound/madplay )"
 
 src_compile () {
-
 	# Needed on mips and probablly others
 	gnuconfig_update
 
@@ -29,6 +28,8 @@ src_compile () {
 
 	# Wave buffer overflow fix.  Adresses Bug #57962
 	epatch ${FILESDIR}/sox-wave-overflow.patch
+	# Wave segfault fix.  Adresses Bug #35745
+	append-flags -fsigned-char
 
 	use oggvorbis || myconf="${myconf} --disable-ogg-vorbis"
 	use mad || myconf="${myconf} --disable-mad"
diff --git a/media-sound/sox/sox-12.17.5-r1.ebuild b/media-sound/sox/sox-12.17.5-r1.ebuild
index 1c19297f301e..d36e15c57349 100644
--- a/media-sound/sox/sox-12.17.5-r1.ebuild
+++ b/media-sound/sox/sox-12.17.5-r1.ebuild
@@ -1,8 +1,8 @@
 # Copyright 1999-2004 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/media-sound/sox/sox-12.17.5-r1.ebuild,v 1.2 2004/09/14 07:43:30 eradicator Exp $
+# $Header: /var/cvsroot/gentoo-x86/media-sound/sox/sox-12.17.5-r1.ebuild,v 1.3 2004/10/17 23:43:09 josejx Exp $
 
-inherit gnuconfig eutils
+inherit gnuconfig eutils flag-o-matic
 
 DESCRIPTION="The swiss army knife of sound processing programs"
 HOMEPAGE="http://sox.sourceforge.net"
@@ -30,6 +30,10 @@ src_compile () {
 	epatch ${FILESDIR}/${PN}-soundcard.patch
 	epatch ${FILESDIR}/${PN}-install.patch
 
+	# Fixes wav segfaults. See Bug #35745.
+	append-flags -fsigned-char
+	use ppc && epatch ${FILESDIR}/${PN}-wav-segfault.patch
+
 	myconf="${myconf} `use_enable oggvorbis ogg-vorbis`"
 	myconf="${myconf} `use_enable mad`"
 	myconf="${myconf} `use_enable encode lame`"