Get Gentoo!
gentoo.org sites
gentoo.org Wiki Bugs Forums Packages
Planet Archives Sources
Infra Status
aboutsummaryrefslogtreecommitdiff
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* virsh: new net-update commandLaine Stump2012-09-202-0/+194
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This command uses the new virNetworkUpdate() API to modify an existing network definition, and optionally have those modifications take effect immediately without restarting the network. An example usage: virsh net-update mynet add-last ip-dhcp-host \ "<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \ --live --config If you like, you can instead put the xml into a file, and call like this: virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml --live --config virsh will autodetect whether the argument is itself an xml element, or if it's a file, by looking at the first character - the first character of an xml element is always "<", and the first character of a file is almost always *not* "<" (in the rare case that it is, the user could specify "./<filename..."). A --parent-index option is also available (to give the index within a list of parent objects, e.g. the index of the parent <ip> element when updating ip-dhcp-host elements), but is optional and at least for now will probably be used rarely. --live, --config, and --current options - if you specify --live, only the live state of the network will be updated. If you also specify --config, then the persistent configuration will also be updated; these two commands can be given separately, or both together. If you don't specify either (you can optionally specify "--current" for the same effect), then the "current" config will be updated (i.e. if the network is active, then only its live config is affected, but if the network is inactive, only the persistent config is affected).
* maint: fix up copyright notice inconsistenciesEric Blake2012-09-2035-35/+35
| | | | | | | | | https://www.gnu.org/licenses/gpl-howto.html recommends that the 'If not, see <url>.' phrase be a separate sentence. * tests/securityselinuxhelper.c: Remove doubled line. * tests/securityselinuxtest.c: Likewise. * globally: s/; If/. If/
* virsh: Move daemon to misc since its not a networkDoug Goldstein2012-09-191-3/+3
| | | | | Move the 'Daemon' entry to the Miscellaneous section since its not a networking driver or component.
* build: define WITH_INTERFACE for the driverDoug Goldstein2012-09-191-1/+4
| | | | | | | | | | | | | | | | | | Based exclusively on work by Eric Blake in a patch posted with the same subject. However some modifications related to comments and my plans to add another backend. Added WITH_INTERFACE as the only automake variable deciding whether to build the driver and using WITH_NETCF to identify that we're wanting to use the netcf library as the backend. * configure.ac: Added with_interface * src/interface/netcf_driver.c: Renamed.. * src/interface/interface_backend_netcf.c: ..to this to match storage. * src/interface/netcf_driver.h: Renamed.. * src/interface/interface_driver.h: ..to this. * daemon/Makefile.am: Respect WITH_INTERFACE and WITH_NETCF. * libvirt.spec.in: Add RPM support for --with-interface
* virsh: Rename QEmu to QEMU to match upstreamDoug Goldstein2012-09-191-1/+1
| | | | | Match upstream's naming of QEMU. There was a notice on the ML that said the preferred spelling was QEMU a while back.
* virsh: Fix resource leaks when editing files.Peter Krempa2012-09-191-2/+5
| | | | | | The cleanup path in virsh-edit helper was never reached when the edit was successful leaking the document in memory as well as the temporary file.
* blockjob: add virsh blockcommitEric Blake2012-09-172-5/+189
| | | | | | | | | | | | | | | | | | The new command 'virsh blockcommit $dom $disk' requests the start of an asynchronous commit operation across the entire chain of $disk. Further arguments can fine-tune which portion of the chain is committed. Existing 'virsh blockjob' commands can then track the status, change the bandwidth, or abort the commit job. With a bit more on the command line, 'virsh blockcommit $dom $disk --wait --verbose' can be used for blocking behavior, with visual feedback on the overall status, and can be canceled with Ctrl-C. The overall design, including the wait loop logic, borrows heavily from the existing blockpull command. * tools/virsh-domain.c (cmdBlockCommit): New function. * tools/virsh.pod (blockcommit): Document it.
* bitmap: new member variable and function renamingHu Tao2012-09-171-1/+1
| | | | | | | Add a new member variable map_len to store map len of bitmap. and rename size to max_bit accordingly. rename virBitmapAlloc to virBitmapNew.
* virsh: Clarify behavior of domain list filtering.Peter Krempa2012-09-171-4/+5
| | | | | Some combinations of filtering flags produce no result. This patch tries to clarify this.
* node_memory: Expose the APIs to virshOsier Yang2012-09-172-0/+124
| | | | | | | | | | | | | | | | | New command node-memory-tune to get/set the node memory parameters, only two parameters are allowed to set (pages_to_scan, and sleep_millisecs, see documents in this patch for more details). Example of node-memory-tune's output: Shared memory: pages_to_scan 100 sleep_millisecs 20 pages_shared 0 pages_sharing 0 pages_unshared 0 pages_volatile 0 full_scans 0
* list: Use virConnectListAllSecrets in virshOsier Yang2012-09-172-31/+182
| | | | | | | | | | | | | | | This introduces four new options for secret-list, to filter the returned secrets by whether it's ephemeral or not, and/or by whether it's private or not. * tools/virsh-secret.c: (New helper vshSecretSorter, vshSecretListFree, and vshCollectSecretList; Use the new API for secret-list; error out if flags are specified, because there is no way to filter the results when using old APIs (no APIs to get the properties (ephemeral, private) of a secret yet). * tools/virsh.pod: Document the 4 new options.
* list: Use virConnectListAllNWFilters in virshOsier Yang2012-09-171-29/+134
| | | | | | | | | | tools/virsh-nwfilter.c: * vshNWFilterSorter to sort network filters by name * vshNWFilterListFree to free the network filter objects list. * vshNWFilterListCollect to collect the network filter objects, trying to use new API first, fall back to older APIs if it's not supported.
* list: Use virConnectListAllNodeDevices in virshOsier Yang2012-09-172-41/+274
| | | | | | | | | | | | | | | tools/virsh-nodedev.c: * vshNodeDeviceSorter to sort node devices by name * vshNodeDeviceListFree to free the node device objects list. * vshNodeDeviceListCollect to collect the node device objects, trying to use new API first, fall back to older APIs if it's not supported. * Change option --cap to accept multiple capability types. tools/virsh.pod * Update document for --cap
* virsh: Don't motify the const stringOsier Yang2012-09-174-13/+18
| | | | | | This improve helper vshStringToArray to accept const string as argument instead. To not convert the const string when using vshStringToArray, and thus avoid motifying it.
* virsh: Fix version numbers in commentsOsier Yang2012-09-133-15/+9
| | | | | | And redundant error resetting. Pushed under trivial rule.
* maint: fix missing spaces in messageEric Blake2012-09-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | I got an off-list report about a bad diagnostic: Target network card mac 52:54:00:49:07:ccdoes not match source 52:54:00:49:07:b8 True to form, I've added a syntax check rule to prevent it from recurring, and found several other offenders. * cfg.mk (sc_require_whitespace_in_translation): New rule. * src/conf/domain_conf.c (virDomainNetDefCheckABIStability): Add space. * src/esx/esx_util.c (esxUtil_ParseUri): Likewise. * src/qemu/qemu_command.c (qemuCollectPCIAddress): Likewise. * src/qemu/qemu_driver.c (qemuDomainSetMetadata) (qemuDomainGetMetadata): Likewise. * src/qemu/qemu_hotplug.c (qemuDomainChangeNetBridge): Likewise. * src/rpc/virnettlscontext.c (virNetTLSContextCheckCertDNWhitelist): Likewise. * src/vmware/vmware_driver.c (vmwareDomainResume): Likewise. * src/vbox/vbox_tmpl.c (vboxDomainGetXMLDesc, vboxAttachDrives): Avoid false negatives. * tools/virsh-domain.c (info_save_image_dumpxml): Reword. Based on a report by Luwen Su.
* list: Use virConnectListAllInterfaces in virshOsier Yang2012-09-121-74/+185
| | | | | | | | | | tools/virsh-interface.c: * vshInterfaceSorter to sort interfaces by name * vshInterfaceListFree to free the interface objects list. * vshInterfaceListCollect to collect the interface objects, trying to use new API first, fall back to older APIs if it's not supported.
* virsh: Fix the typosOsier Yang2012-09-111-14/+14
| | | | * tools/virsh-network.c: s/MATCH/VSH_MATCH/
* list: Use virConnectListAllNetworks in virshOsier Yang2012-09-112-89/+275
| | | | | | | | | | | | | | | | tools/virsh-network.c: * vshNetworkSorter to sort networks by name * vshNetworkListFree to free the network objects list. * vshNetworkListCollect to collect the network objects, trying to use new API first, fall back to older APIs if it's not supported. * New options --persistent, --transient, --autostart, --no-autostart, for net-list, and new field 'Persistent' for its output. tools/virsh.pod: * Add documents for the new options.
* list: Use virStoragePoolListAllVolumes in virshOsier Yang2012-09-101-47/+150
| | | | | | | | | | tools/virsh-volume.c: * vshStorageVolSorter to sort storage vols by name * vshStorageVolumeListFree to free the volume objects list * vshStorageVolumeListCollect to collect the volume objects, trying to use new API first, fall back to older APIs if it's not supported.
* virsh: Update only changed scheduler tunablesPeter Krempa2012-09-071-90/+74
| | | | | | | | | | | | | | | | | When setting the cpu tunables in virsh you are able to update only a subset of them. Virsh while doing the update updated all of the tunables, changed ones with new values and unchanged with old ones. This is unfortunate as it: a) might overwrite some other change by a race condition (unprobable) b) fails with range checking as some of the old values saved might be out of range This patch changes the update procedure so that only the changed value is updated on the host. This patch also fixes a very unprobable memory leak if the daemon would return a string tunable parameter, as the typed parameter array was not cleared.
* virsh: Improve the document for pool-listOsier Yang2012-09-071-4/+4
| | | | Which is lost by commit 93a346d353.
* list: fix typo in virsh patchEric Blake2012-09-061-15/+15
| | | | | | | | A last minute rename in commit fc122e1a to virsh.h was not properly reflected when rebasing virsh-pool.c in commit 93a346d. * tools/virsh-pool.c (vshStoragePoolListCollect): Use VSH_MATCH, not MATCH.
* list: Use virConnectListAllStoragePools in virshOsier Yang2012-09-062-100/+358
| | | | | | | | | | | | | | | | | | | | | | | | | | | tools/virsh-pool.c: * vshStoragePoolSorter to sort the pool list by pool name. * struct vshStoragePoolList to present the pool list, pool info is collected by list->poolinfo if 'details' is specified by user. * vshStoragePoolListFree to free the pool list * vshStoragePoolListCollect to collect the pool list, new API virStorageListAllPools is tried first, if it's not supported, fall back to older APIs. * New options --persistent, --transient, --autostart, --no-autostart and --type for pool-list. --persistent or --transient is to filter the returned pool list by whether the pool is persistent or not. --autostart or --no-autostart is to filter the returned pool list by whether the pool is autostarting or not. --type is to filter the pools by pool types. E.g. % virsh pool-list --all --persistent --type dir,disk tools/virsh.pod: * Add documentations for the new options.
* list: Change MATCH for common use in virshOsier Yang2012-09-062-23/+23
| | | | | | | | Move definition of MATCH from virsh-domain-monitor.c into virsh.h, and rename it as VSH_MATCH for further use. * tools/virsh-domain-monitor.c: Change MATCH into VSH_MATCH * tools/virsh.h: Define VSH_MATCH
* virsh: Fix the wrong doc for pool-listOsier Yang2012-09-061-5/+4
| | | | | | The storage pool's management doesn't relate with a domain, it probably was an intention, but not achieved yet. And the fact is only active pools are listed by default.
* list: Add helper to convert strings separated by ', ' to arrayOsier Yang2012-09-063-17/+47
| | | | | | tools/virsh.c: New helper function vshStringToArray. tools/virsh.h: Declare vshStringToArray. tools/virsh-domain.c: use the helper in cmdUndefine.
* build: use re-entrant functions in virshEric Blake2012-09-053-21/+32
| | | | | | | | | | | | | | | | Yesterday's commit 15d2c9f pointed out that virsh was still using localtime(), which is not thread-safe, even though virsh is definitely multi-threaded. Even if we only ever triggered it from one thread, it's better safe than sorry for maintenance purposes. * cfg.mk (exclude_file_name_regexp--sc_prohibit_nonreentrant): Tighten the rule. * tools/virsh.c (vshOutputLogFile): Avoid localtime. (vshEditWriteToTempFile, vshEditReadBackFile, cmdCd, cmdPwd) (vshCloseLogFile): Avoid strerror. * tools/console.c (vshMakeStdinRaw): Likewise. * tools/virsh-domain.c (vshGenFileName): Fix spacing in previous patch.
* docs: correct dompmwakeup descriptionMartin Kletzander2012-09-052-6/+7
|
* Pass a correct pointer type to localtime_r(3).Paul Eggert2012-09-042-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On 09/04/2012 08:20 AM, Eric Blake wrote: > tv_sec is required by POSIX to be > of type time_t; so this is a bug in the OpenBSD header > [for declaring it as long] Most likely this problem arose because of the patch I pushed in gnulib commit e07d7c40f3ca5ec410cf5aa6fa03cfe51e712039. Previously, gnulib required timeval's tv_sec to be the same size as time_t. But now, it requires only that tv_sec be big enough to hold a time_t. This patch was needed for Emacs. Without the patch, gnulib replaced struct timeval on OpenBSD, and this messed up utimens.c, and Emacs wouldn't build. Alternatively, gnulib could substitute its own struct timeval for the system's, wrapping every struct timeval-using function (gettimeofday, futimesat, futimes, lutimes, etc. That'd be more work, though. And it would introduce some performance issues with gettimeofday, which is supposed to be fast. I've been trying to get away from using struct timeval, and to use the higher-resolution struct timespec instead, so messing with these obsolescent interfaces has been lower priority for me. But if someone wants to take the more-ambitious approach that'd be fine, I expect. For this particular case, though, how about if we avoid the problem entirely? libvirt doesn't need to use struct timeval here at all. It makes libvirt smaller and probably faster, and it ports to OpenBSD without messing with gnulib.
* virsh: remove unneeded usage of vshConnectionUsability()Peter Krempa2012-08-3113-572/+17
| | | | | | | | Now that vshCommandRun() checks for the connection automaticaly, remove all of the redundant checks in the code. vshConnectionUsability() no longer needs to be exported and this patch marks it static.
* virsh: Improve checking for connection when running commandsPeter Krempa2012-08-311-9/+19
| | | | | | | | | | | Almost each virsh command uses the function vshConnectionUsability before doing anything, to check if the connection is "alive". Commands that don't need an conection are already conveniently marked with VSH_CMD_FLAG_NOCONNECT. We can automaticaly check for the connection before calling any remote command so we don't forget to do so. This patch also upgrades the connection check to use virConnectIsAlive along with the current approach.
* virsh: fixed incorrect timing reportViktor Mihajlovski2012-08-311-1/+1
| | | | | | | | When executing virsh -t <command> the reported timing was off by 3 orders of magnitude if the command took more than one second. Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
* virsh: Document subdriver option of attach-diskJiri Denemark2012-08-311-3/+9
|
* doc: update option force to subcommand change-mediaGuannan Ren2012-08-311-1/+1
| | | | BZ: https://bugzilla.redhat.com/show_bug.cgi?id=837761
* virsh: fix missing return valueAlex Jia2012-08-271-0/+3
| | | | | | | Although virsh command raises a correct error information, the command status returns 0(true), this patch is used for fixing this issue. Signed-off-by: Alex Jia <ajia@redhat.com>
* agent: add qemu-agent-command to virshMATSUDA Daiki2012-08-232-0/+102
| | | | | | Add qemu-agent-command to virsh to support virDomainQemuAgentCommand(). Signed-off-by: MATSUDA Daiki <matsudadik@intellilink.co.jp>
* docs: fix blockpull/blockcopy bandwidth Mbps -> MiB/sStefan Hajnoczi2012-08-221-2/+2
| | | | | | | The bandwidth units for blockpull and blockcopy are in Megabytes per Second, not Megabits per Second. Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
* virsh: don't print error info when snapshot xml is not changedGuannan Ren2012-08-221-3/+3
| | | | | If xml is not changed, error message is printed. So check ret value instead of edit variable for error message.
* new interface to control emulator_period/emulator_quotaHu Tao2012-08-221-5/+6
| | | | | | This patch adds two macros: VIR_DOMAIN_SCHEDULER_EMULATOR_PERIOD, VIR_DOMAIN_SCHEDULER_EMULATOR_QUOTA for controlling cpu bandwidth for emulator activities not tied to vcpus
* new command emulatorpinHu Tao2012-08-222-0/+204
|
* Add a new function vshPrintPinInfo.Hu Tao2012-08-221-23/+42
| | | | This is a helper function to print vcpu pin info.
* output status information during guest shutdown againGerd v. Egidy2012-08-212-15/+51
| | | | | | | | | | | | Since the move to systemd libvirt-guests doesn't output this progress information anymore. This patch brings back this feature. It is helpful to show the admin what the system is waiting for and what is left of the timeout (e.g. for calibrating the shutdown timing of a ups). Rewriting the current line with \r doesn't work anymore in the context of systemd. So always write new lines, but move to 5 second intervals to avoid flooding the console.
* virsh: split out virsh-volume.cEric Blake2012-08-214-15/+70
| | | | | | | | | | Last of the file splits. * tools/virsh-volume.h: New file. * tools/Makefile.am (virsh_SOURCES): Build it. * tools/virsh.c: Use new header. * tools/virsh-volume.c: Likewise. (vshCommandOptVolBy): Fix flag usage.
* virsh: split out virsh-snapshot.cEric Blake2012-08-214-4/+54
| | | | | | | | | Almost done with the splits. * tools/virsh-snapshot.h: New file. * tools/Makefile.am (virsh_SOURCES): Build it. * tools/virsh.c: Use new header. * tools/virsh-snapshot.c: Likewise.
* virsh: split out virsh-secret.cEric Blake2012-08-214-3/+51
| | | | | | | | | One of the simpler splits. * tools/virsh-secret.h: New file. * tools/Makefile.am (virsh_SOURCES): Build it. * tools/virsh.c: Use new header. * tools/virsh-secret.c: Likewise.
* virsh: split out virsh-pool.cEric Blake2012-08-214-11/+63
| | | | | | | | | | More in a series of file splits. * tools/virsh-pool.h: New file. * tools/Makefile.am (virsh_SOURCES): Build it. * tools/virsh.c: Use new header. * tools/virsh-pool.c: Likewise. (virCommandOptPoolBy): Fix flag usage.
* virsh: split out virsh-nwfilter.cEric Blake2012-08-214-12/+65
| | | | | | | | | Yet another split file. * tools/virsh-nwfilter.h: New file. * tools/Makefile.am (virsh_SOURCES): Build it. * tools/virsh.c: Use new header. * tools/virsh-nwfilter.c: Likewise.
* virsh: split out virsh-nodedev.cEric Blake2012-08-215-8/+57
| | | | | | | | | | | Another worthwhile split, needed one more public function. * tools/virsh-nodedev.h: New file. * tools/Makefile.am (virsh_SOURCES): Build it. * tools/virsh-nodedev.c: Use new header. * tools/virsh.c: Likewise. (vshTreePrint): Export. * tools/virsh.h (vshTreePrint): Declare.
* virsh: split out virsh-network.cEric Blake2012-08-214-11/+64
| | | | | | | | | | Another relatively easy file split. * tools/virsh-network.h: New file. * tools/Makefile.am (virsh_SOURCES): Build it. * tools/virsh.c: Use new header. * tools/virsh-network.c: Likewise. (vshCommandOptNetworkBy): Update signature.