summaryrefslogtreecommitdiff
path: root/src/uml
diff options
context:
space:
mode:
authorLaine Stump <laine@laine.org>2012-03-01 15:35:30 -0500
committerLaine Stump <laine@laine.org>2012-03-02 16:04:06 -0500
commitd1c310231dd0c4cea989cc5e35a9911b38f7cacf (patch)
tree69b3ab28185c631f13c96de1e91e9f6359a23de2 /src/uml
parentutil: centralize tap device MAC address 1st byte "0xFE" modification (diff)
downloadlibvirt-d1c310231dd0c4cea989cc5e35a9911b38f7cacf.tar.gz
libvirt-d1c310231dd0c4cea989cc5e35a9911b38f7cacf.tar.bz2
libvirt-d1c310231dd0c4cea989cc5e35a9911b38f7cacf.zip
util: combine bools in virNetDevTapCreateInBridgePort into flags
With an additional new bool added to determine whether or not to discourage the use of the supplied MAC address by the bridge itself, virNetDevTapCreateInBridgePort had three booleans (well, 2 bools and an int used as a bool) in the arg list, which made it increasingly difficult to follow what was going on. This patch combines those three into a single flags arg, which not only shortens the arg list, but makes it more self-documenting.
Diffstat (limited to 'src/uml')
-rw-r--r--src/uml/uml_conf.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/uml/uml_conf.c b/src/uml/uml_conf.c
index c7b29a0c5..89fdd9fb4 100644
--- a/src/uml/uml_conf.c
+++ b/src/uml/uml_conf.c
@@ -1,7 +1,7 @@
/*
* uml_conf.c: UML driver configuration
*
- * Copyright (C) 2006-2011 Red Hat, Inc.
+ * Copyright (C) 2006-2012 Red Hat, Inc.
* Copyright (C) 2006 Daniel P. Berrange
*
* This library is free software; you can redistribute it and/or
@@ -138,9 +138,9 @@ umlConnectTapDevice(virConnectPtr conn,
template_ifname = true;
}
- if (virNetDevTapCreateInBridgePort(bridge, &net->ifname, net->mac, true,
- 0, true, NULL,
- virDomainNetGetActualVirtPortProfile(net)) < 0) {
+ if (virNetDevTapCreateInBridgePort(bridge, &net->ifname, net->mac, NULL,
+ virDomainNetGetActualVirtPortProfile(net),
+ VIR_NETDEV_TAP_CREATE_IFUP) < 0) {
if (template_ifname)
VIR_FREE(net->ifname);
goto error;