diff options
| author |   Chris Lalancette <clalance@redhat.com> | 2010-04-23 11:59:39 -0400 |
|---|---|---|
| committer | Chris Lalancette <clalance@redhat.com> | 2010-04-23 14:23:27 -0400 |
| commit | 52ae076a941b04f4196fe37c4972a783c2120112 (patch) | |
| tree | d60b48a7116a41ede1995bfbbdfc2b676485159c | |
| parent | Fix printing of pathnames on error in qemuDomainSnapshotLoad. (diff) | |
| download | libvirt-52ae076a941b04f4196fe37c4972a783c2120112.tar.gz libvirt-52ae076a941b04f4196fe37c4972a783c2120112.tar.bz2 libvirt-52ae076a941b04f4196fe37c4972a783c2120112.zip | |
Fix memory leak in virsh snapshot-list.
We were forgetting to release the memory allocated by
virDomainSnapshotListNames. Free the memory properly.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
| -rw-r--r-- | tools/virsh.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/virsh.c b/tools/virsh.c index b2a1538b8..5bcf0ede9 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -8360,7 +8360,7 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd) int ret = FALSE; int numsnaps; char **names = NULL; - int actual; + int actual = 0; int i; xmlDocPtr xml = NULL; xmlXPathContextPtr ctxt = NULL; @@ -8447,6 +8447,8 @@ cleanup: if (xml) xmlFreeDoc(xml); VIR_FREE(doc); + for (i = 0; i < actual; i++) + VIR_FREE(names[i]); VIR_FREE(names); if (dom) virDomainFree(dom); |