From 75aab18b528a3b76355da6fc6b36e4c6635375b8 Mon Sep 17 00:00:00 2001
From: Ulrich Müller <ulm@gentoo.org>
Date: Mon, 30 Oct 2023 17:13:38 +0100
Subject: devbook.xsl: Update the findNext template for relative links
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Create relative links with correct depth. Some other simplifications.

Signed-off-by: Ulrich Müller <ulm@gentoo.org>
---
 devbook.xsl | 32 +++++++++-----------------------
 1 file changed, 9 insertions(+), 23 deletions(-)

diff --git a/devbook.xsl b/devbook.xsl
index 8d4e1df..668fa01 100644
--- a/devbook.xsl
+++ b/devbook.xsl
@@ -774,28 +774,16 @@
         <!-- If we have an item after us, or we are at the root node
              (termination condition) we need to not recurse any further... -->
         <xsl:when test="$parentItem_lookup != '' or document(concat($self, '../text.xml'))/guide/@root">
-          <xsl:variable name="parentItem_actual">
-            <xsl:choose>
-              <xsl:when test="$parentItem_next = ''"></xsl:when>
-              <xsl:otherwise><xsl:value-of select="$parentItem_next"/></xsl:otherwise>
-            </xsl:choose>
-          </xsl:variable>
-          <!-- This is where we do a little trickery. To count how many levels
-               we need to go down, we count how far up we currently are
-               (remember that the absolute link we get is relative to /...)
-               and hence we can build a relative link... -->
-          <xsl:variable name="relative_path" select="$parentItem_actual"/>
-          <xsl:variable name="relative_path_depth"
-                        select="string-length(/guide/@self) - string-length(translate(/guide/@self, '/' , ''))"/>
-          <xsl:variable name="relative_path_depth_recursion">
-            <xsl:call-template name="str:repeatString">
-              <xsl:with-param name="count" select="$relative_path_depth"/>
-              <xsl:with-param name="append">../</xsl:with-param>
+          <!-- Compute a relative path for the link. -->
+          <xsl:variable name="path_rel">
+            <xsl:call-template name="relative-path">
+              <xsl:with-param name="path" select="$parentItem_next"/>
+              <xsl:with-param name="self" select="/guide/@self"/>
             </xsl:call-template>
           </xsl:variable>
-          <a class="w-250 text-center" href="{concat($relative_path_depth_recursion, $relative_path, 'index.html')}">
+          <a class="w-250 text-center" href="{concat($path_rel, 'index.html')}">
             <span class="truncated-text d-inline-block max-w-200 mr-2">
-              <xsl:value-of select="document(concat($parentItem_actual, 'text.xml'))/guide/chapter[1]/title"/>
+              <xsl:value-of select="document(concat($parentItem_next, 'text.xml'))/guide/chapter[1]/title"/>
             </span>
             <span class="fa fa-arrow-right"/>
           </a>
@@ -803,11 +791,9 @@
         <xsl:otherwise>
           <!-- We need to recurse downwards; so we need to strip off a directory
                element off our absolute path to feed into the next iteration... -->
-          <xsl:variable name="relative_path_depth"
-                        select="string-length($self) - string-length(translate($self, '/' , ''))"/>
           <xsl:variable name="relative_path_fixed">
-            <xsl:for-each select="str:tokenize_plasmaroo($self, '/')[position() &lt; (($relative_path_depth - 1)*2 + 1)]">
-              <xsl:value-of select="."/>
+            <xsl:for-each select="str:tokenize($self, '/')[position() &lt; last()]">
+              <xsl:value-of select="concat(., '/')"/>
             </xsl:for-each>
           </xsl:variable>
           <xsl:call-template name="findNext">
-- 
cgit v1.2.3-65-gdbad