blob: dc0bb4a70fc8007aaf3d3c46209a9c9bbe6c916b (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
|
#!/bin/bash
# Verify that GCO sign-off is present in commit messages
# Copyright 2018 Michał Górny
# Distributed under the terms of the GNU General Public License v2 or later
# Disable filename expansion
set -f
# Force UTF-8
export LC_CTYPE=en_US.UTF-8
# Make == case-insensitive
shopt -s nocasematch
# --- Command line
refname=${1}
oldrev=${2}
newrev=${3}
# --- Safety check
if [[ -z ${GIT_DIR} ]]; then
echo "Don't run this script from the command line." >&2
echo " (if you want, you could supply GIT_DIR then run" >&2
echo " ${0} <ref> <oldrev> <newrev>)" >&2
exit 1
fi
if [[ -z ${refname} || -z ${oldrev} || -z ${newrev} ]]; then
echo "usage: ${0} <ref> <oldrev> <newrev>" >&2
exit 1
fi
# Gentoo devs get extra realname checks
get_from_ldif() {
local key=${1}
local line
while read -r line; do
case ${line} in
"${key}:: "*)
# base64-encoded value
base64 -d <<<"${line#*:: }"
break
;;
"${key}: "*)
echo "${line#*: }"
break
;;
esac
done
}
if [[ ${GL_USER} == *@gentoo.org ]]; then
ldif=$(ldapsearch "uid=${GL_USER%@gentoo.org}" -D '' -Z -LLL \
cn gecos -o ldif-wrap=no)
cn_expected=$(get_from_ldif cn <<<"${ldif}")
gecos_expected=$(get_from_ldif gecos <<<"${ldif}")
if [[ -z ${cn_expected} ]]; then
echo "Unable to get cn for ${GL_USER}, please report!" >&2
exit 1
fi
if [[ -z ${gecos_expected} ]]; then
echo "Unable to get gecos for ${GL_USER}, please report!" >&2
exit 1
fi
fi
ret=0
# special cases
zeros=0000000000000000000000000000000000000000
# branch removal
[[ ${newrev} == "${zeros}" ]] && exit 0
# new branch; try to find a merge base with master
if [[ ${oldrev} == "${zeros}" && ${refname} != refs/heads/master ]]; then
mergebase=$(git merge-base refs/heads/master "${newrev}")
[[ -n ${mergebase} ]] && oldrev=${mergebase}
[[ -z ${mergebase} ]] && echo "WARNING: No common commits with master!"
fi
rev_list_arg="${oldrev}..${newrev}"
# new and no common commit? gotta check them all
[[ ${oldrev} == "${zeros}" ]] && rev_list_arg="${newrev}"
while read -r commithash; do
# verify that the commit message contains Signed-off-by
signoff=no
committer=$(git show -q --pretty=format:'%ce' "${commithash}")
while read -r line; do
if [[ ${line} == signed-off-by:* ]]; then
# verify syntax first. should be:
# Signed-off-by: Real Name <email@address> [(maybe something)]
if [[ ${line} != 'signed-off-by: '*' <'*@*.*'>'* ]]; then
signoff=syntaxerr
break
fi
# verify that DCO-1.1 is not used on licenses directory
# (suggested by leio)
if [[ ${line} == *DCO[-\ ]1* ]]; then
while read -r -d $'\0' filename; do
if [[ ${filename} == licenses/* ]]; then
signoff=dcolicense
break 2
fi
done < <(git diff -z --name-only "${commithash}^" "${commithash}")
fi
# if we already found the correct one, just verify syntax
# of the rest
[[ ${signoff} == ok ]] && continue
# strip the key
line=${line#*: }
mail=${line#*<}
mail=${mail%%>*}
# different mail? try other signoffs, maybe reject.
if [[ ${mail} != "${committer}" ]]; then
signoff=diffmail
continue
fi
# is it the dev? verify real name then.
if [[ ${GL_USER} == *@gentoo.org && ${GL_USER} == "${committer}" ]]; then
realname=${line%% <*}
# require either CN or GECOS to match (to allow
# for ASCII spelling)
# also allow for a single comment after the name
# e.g. for nickname, requested by jmbsvicetto
if [[ ${realname} != "${cn_expected}" \
&& ${realname} != "${gecos_expected}" \
&& ${realname% (*} != "${cn_expected}" \
&& ${realname% (*} != "${gecos_expected}" ]]
then
signoff=diffname
break
fi
fi
signoff=ok
fi
done < <(git show -q --pretty=format:'%b' "${commithash}")
case ${signoff} in
no)
echo "${commithash}: missing Signed-off-by on commit"
ret=1;;
syntaxerr)
echo "${commithash}: malformed Signed-off-by (should be: real name <email>)!"
echo " ${line}"
ret=1;;
dcolicense)
echo "${commithash}: DCO-1.1 Signed-off-by used on license directory!"
ret=1;;
diffmail)
echo "${commithash}: no Signed-off-by line matching committer's e-mail address found!"
echo " expected: ${committer}"
echo " last found: ${mail}"
ret=1;;
diffname)
echo "${commithash}: name in Signed-off-by does not match realname in LDAP!"
echo " expected: ${cn_expected} (${gecos_expected})"
echo " last found: ${realname}"
ret=1;;
esac
done < <(git rev-list "${rev_list_arg}")
if [[ ${ret} == 1 ]]; then
echo
echo "Please make sure to read the copyright policy before adding Signed-off-by!"
echo " https://www.gentoo.org/glep/glep-0076.html"
fi
# --- Finished
exit "${ret}"
|
GitWeb