summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2016-02-09 21:39:49 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2016-02-09 21:39:49 +0000
commita0ff556aa10f868349e1a1d88e6fd8b147565186 (patch)
treebdc9b205d83cd36b3a0af5119f04c057c4748d7e
parentFix incorrect usage of `str` in _match_decorator_property. (diff)
downloadllvm-project-a0ff556aa10f868349e1a1d88e6fd8b147565186.tar.gz
llvm-project-a0ff556aa10f868349e1a1d88e6fd8b147565186.tar.bz2
llvm-project-a0ff556aa10f868349e1a1d88e6fd8b147565186.zip
This brings back commit r259578.
But now it follows the llvm style, uses an early return and doesn't include a file named 1.o. llvm-svn: 260293
-rw-r--r--llvm/test/tools/llvm-size/X86/ignore-sections.s28
-rw-r--r--llvm/test/tools/llvm-size/X86/lit.local.cfg2
-rw-r--r--llvm/tools/llvm-size/llvm-size.cpp20
3 files changed, 50 insertions, 0 deletions
diff --git a/llvm/test/tools/llvm-size/X86/ignore-sections.s b/llvm/test/tools/llvm-size/X86/ignore-sections.s
new file mode 100644
index 000000000000..1f331d62bb6e
--- /dev/null
+++ b/llvm/test/tools/llvm-size/X86/ignore-sections.s
@@ -0,0 +1,28 @@
+// RUN: llvm-mc %s -o %t.o -filetype=obj -triple=x86_64-pc-linux
+// RUN: llvm-size -A %t.o | FileCheck --check-prefix="SYSV" %s
+// RUN: llvm-size -B %t.o| FileCheck --check-prefix="BSD" %s
+
+ .text
+ .zero 4
+ .data
+ .long foo
+ .bss
+ .zero 4
+ .ident "foo"
+ .section foo
+ .long 42
+ .cfi_startproc
+ .cfi_endproc
+
+// SYSV: {{[ -\(\)_A-Za-z0-9.\\/:]+}} :
+// SYSV-NEXT: section size addr
+// SYSV-NEXT: .text 4 0
+// SYSV-NEXT: .data 4 0
+// SYSV-NEXT: .bss 4 0
+// SYSV-NEXT: .comment 5 0
+// SYSV-NEXT: foo 4 0
+// SYSV-NEXT: .eh_frame 48 0
+// SYSV-NEXT: Total 69
+
+// BSD: text data bss dec hex filename
+// BSD-NEXT: 4 4 4 12 c {{[ -\(\)_A-Za-z0-9.\\/:]+}}
diff --git a/llvm/test/tools/llvm-size/X86/lit.local.cfg b/llvm/test/tools/llvm-size/X86/lit.local.cfg
new file mode 100644
index 000000000000..c8625f4d9d24
--- /dev/null
+++ b/llvm/test/tools/llvm-size/X86/lit.local.cfg
@@ -0,0 +1,2 @@
+if not 'X86' in config.root.targets:
+ config.unsupported = True
diff --git a/llvm/tools/llvm-size/llvm-size.cpp b/llvm/tools/llvm-size/llvm-size.cpp
index 7b1b9c6f93ab..aacbe9e25b9a 100644
--- a/llvm/tools/llvm-size/llvm-size.cpp
+++ b/llvm/tools/llvm-size/llvm-size.cpp
@@ -15,6 +15,7 @@
#include "llvm/ADT/APInt.h"
#include "llvm/Object/Archive.h"
+#include "llvm/Object/ELFObjectFile.h"
#include "llvm/Object/MachO.h"
#include "llvm/Object/MachOUniversal.h"
#include "llvm/Object/ObjectFile.h"
@@ -111,6 +112,21 @@ static const char *getRadixFmt() {
return nullptr;
}
+/// Remove unneeded ELF sections from calculation
+static bool considerForSize(ObjectFile *Obj, SectionRef Section) {
+ if (!Obj->isELF())
+ return true;
+ switch (static_cast<ELFSectionRef>(Section).getType()) {
+ case ELF::SHT_NULL:
+ case ELF::SHT_SYMTAB:
+ case ELF::SHT_STRTAB:
+ case ELF::SHT_REL:
+ case ELF::SHT_RELA:
+ return false;
+ }
+ return true;
+}
+
/// Print the size of each Mach-O segment and section in @p MachO.
///
/// This is when used when @c OutputFormat is darwin and produces the same
@@ -287,6 +303,8 @@ static void printObjectSectionSizes(ObjectFile *Obj) {
std::size_t max_size_len = strlen("size");
std::size_t max_addr_len = strlen("addr");
for (const SectionRef &Section : Obj->sections()) {
+ if (!considerForSize(Obj, Section))
+ continue;
uint64_t size = Section.getSize();
total += size;
@@ -322,6 +340,8 @@ static void printObjectSectionSizes(ObjectFile *Obj) {
// Print each section.
for (const SectionRef &Section : Obj->sections()) {
+ if (!considerForSize(Obj, Section))
+ continue;
StringRef name;
if (error(Section.getName(name)))
return;